Repository navigation
[ty] Check packed AST index bounds - #27849
Merged
charliermarsh merged 1 commit intoAug 18, 2026
Merged
Conversation
Memory usage reportMemory usage unchanged ✅ |
|
Member
|
Thank you, will take this. |
charliermarsh
approved these changes
Aug 18, 2026
charliermarsh
requested review from
charliermarsh
and removed request for
MichaReiser
August 18, 2026 23:12
Member
|
LGTM. |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An out-of-range
NodeIndexin the final packed chunk can read padding instead of rejecting the lookup. That padding can decode to an address and node kind that were never recorded together, violating the invariant used to reconstruct an AST reference.Check the chunk's actual entry count before decoding either representation, so invalid lookups fail before reconstructing a reference.