Repository navigation
Move pytest-fixture-autouse to restriction - #28219
Merged
Merged
Conversation
|
ntBre
changed the title
restriction categorypytest-fixture-autouse to restriction
ntBre
added
preview
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
restrictioncategory description refers to “language features”. I made the wording more general so it can also apply to 3rd party APIs.I switched one rule,
pytest-fixture-autouseinto there, as it bans a feature that is both considered idiomatic and has no replacement, which was pointed out by a pytest maintainer and several users:pytest.fixture(autouse=True)#12491The rule has been disabled because it was so contentious, only to later be placed into the
pedanticcategories with many rules that actually improve most code bases. This puts it in the appropriate category.Test Plan
I ran all the tests, and grepped the docs grepped for “restriction” and “language feature” to make sure I didn’t miss any spot where the categories are described.