Skip to content

Validate unary expressions when parsing #28233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntBre merged 1 commit into from
Sep 2, 2026
Merged

Validate unary expressions when parsing #28233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/ruff_python_parser/resources/inline/err/signed_pattern_non_literal_operand.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# parse_options: {"target-version": "3.15"}
match value:
case -1**2: ...
case -1 .real: ...
case -1[0]: ...
case -1(): ...
case {+1**2: _}: ...
20 changes: 20 additions & 0 deletions crates/ruff_python_parser/src/parser/pattern.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,26 @@ impl Parser<'_> {
ExpressionContext::default(),
);

// test_err signed_pattern_non_literal_operand
// # parse_options: {"target-version": "3.15"}
// match value:
// case -1**2: ...
// case -1 .real: ...
// case -1[0]: ...
// case -1(): ...
// case {+1**2: _}: ...

// Parse the full operand for error recovery, but only numeric literals
// are valid after a sign in a literal pattern.
if !unary_expr.operand.is_number_literal_expr() {
self.add_error(
ParseErrorType::OtherError(
"Expected a numeric literal after unary operator".to_string(),
),
unary_expr.operand.range(),
);
}

// test_ok unary_plus_py315
// # parse_options: {"target-version": "3.15"}
// match foo:
Expand Down
Loading
Loading