Skip to content

[ty] Compact reachable binding and declaration histories - #28349

Merged
charliermarsh merged 3 commits into
mainfrom
charlie/codex-ty-share-reachable-histories
Sep 16, 2026
Merged

charliermarsh merged 3 commits into
mainfrom
charlie/codex-ty-share-reachable-histories

Conversation

@charliermarsh

@charliermarsh charliermarsh commented Sep 6, 2026 •

Copy link
Copy Markdown
Member

Summary

We retain duplicate binding and declaration lists because reachable histories include implicit unbound/undeclared entries that end-of-scope histories can discard. We now store those initial entries as one reachability constraint per place and intern the remaining definitions, reusing the corresponding end-of-scope declaration list when it matches.

@charliermarsh charliermarsh added the ty The ty type checker label Sep 6, 2026
@astral-sh-bot

astral-sh-bot Bot commented Sep 6, 2026

Copy link
Copy Markdown

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 97.84%. The percentage of expected errors that received a diagnostic held steady at 96.45%. The number of fully passing files held steady at 128/145.

@astral-sh-bot

astral-sh-bot Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

Memory usage report

Summary

Project Old New Diff Outcome
flake8 39.03MB 38.55MB -1.22% (488.73kB) ⬇️
trio 94.64MB 93.70MB -0.99% (961.25kB) ⬇️
sphinx 169.28MB 167.72MB -0.92% (1.56MB) ⬇️
prefect 471.78MB 467.70MB -0.87% (4.09MB) ⬇️

Significant changes

Click to expand detailed breakdown

flake8

Name Old New Diff Outcome
semantic_index 9.96MB 9.48MB -4.79% (488.73kB) ⬇️

trio

Name Old New Diff Outcome
semantic_index 20.08MB 19.14MB -4.67% (961.25kB) ⬇️

sphinx

Name Old New Diff Outcome
semantic_index 34.09MB 32.53MB -4.58% (1.56MB) ⬇️

prefect

Name Old New Diff Outcome
semantic_index 90.61MB 86.52MB -4.51% (4.09MB) ⬇️

@astral-sh-bot

astral-sh-bot Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.

Full report with detailed diff (timing results)

@charliermarsh
charliermarsh force-pushed the charlie/codex-ty-share-reachable-histories branch from 5e0e9bb to 4fa3c51 Compare September 6, 2026 11:47
@charliermarsh
charliermarsh marked this pull request as ready for review September 6, 2026 11:48
@charliermarsh
charliermarsh requested a review from a team as a code owner September 6, 2026 11:48
@charliermarsh charliermarsh added the performance Potential performance improvement label Sep 6, 2026
@astral-sh-bot
astral-sh-bot Bot requested a review from dcreager September 6, 2026 11:48

@dcreager dcreager left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@charliermarsh
charliermarsh merged commit 94efeaa into main Sep 16, 2026
69 checks passed
@charliermarsh
charliermarsh deleted the charlie/codex-ty-share-reachable-histories branch September 16, 2026 14:14
carljm added a commit that referenced this pull request Sep 16, 2026
…aliases

* origin/main:
  Bump version to 0.16.8 (#28648)
  [ty] Bound aliased intersection expansion during inference (#28546)
  renovate: update uv hashes correctly with setup-uv (#28621)
  [ty] Compact reachable binding and declaration histories (#28349)
  [ty] Avoid storing constraint nodes twice (#28375)
  [ty] Compare bound-method receivers before signatures (#28384)
  [`flake8-type-checking`] Prefer lazy imports over `TYPE_CHECKING` on 3.15+ (`TC001`, `TC002`, `TC003`) (#28541)
  [ty] Watch script dependencies in CLI watch mode (#28125)
  [flake8-tidy-imports] Add `extend-banned-api` (#28644)
  [ty] Support `type[A & B]` (#27124)

# Conflicts:
#	crates/ty_python_semantic/src/types/set_theoretic/builder.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Potential performance improvement ty The ty type checker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants