Repository navigation
[ty] Share attribute write compatibility checks - #28555
Merged
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 97.84%. The percentage of expected errors that received a diagnostic held steady at 96.45%. The number of fully passing files held steady at 128/145. |
Memory usage reportMemory usage unchanged ✅ |
|
charliermarsh
force-pushed
the
charlie/share-attribute-write-checks
branch
from
September 12, 2026 20:58
56bde8f to
cd3fc10
Compare
charliermarsh
added this pull request to stack #28558
September 12, 2026 20:59
charliermarsh
added
the
internal
charliermarsh
force-pushed
the
charlie/share-attribute-write-checks
branch
2 times, most recently
from
September 13, 2026 13:04
80f8e34 to
9567718
Compare
charliermarsh
removed this pull request from stack #28558
September 13, 2026 13:06
charliermarsh
changed the base branch from
main
to
charlie/synthesized-match-args-classvar
September 13, 2026 13:06
charliermarsh
added this pull request to stack #28564
September 13, 2026 13:07
charliermarsh
force-pushed
the
charlie/share-attribute-write-checks
branch
from
September 13, 2026 13:59
9567718 to
e02da0d
Compare
charliermarsh
removed this pull request from stack #28564
September 13, 2026 13:59
charliermarsh
changed the base branch from
charlie/synthesized-match-args-classvar
to
charlie/generic-property-setter-domains
September 13, 2026 14:00
charliermarsh
added this pull request to stack #28566
September 13, 2026 14:00
charliermarsh
marked this pull request as ready for review
September 14, 2026 13:34
charliermarsh
requested review from
AlexWaygood
and removed request for
dcreager
September 14, 2026 13:34
AlexWaygood
approved these changes
Sep 14, 2026
AlexWaygood
left a comment
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
(did not review in depth, I assume this is just moving code from one module to another, and that seems good!)
charliermarsh
removed this pull request from stack #28566
September 14, 2026 14:10
charliermarsh
changed the base branch from
charlie/generic-property-setter-domains
to
main
September 14, 2026 14:11
charliermarsh
force-pushed
the
charlie/share-attribute-write-checks
branch
from
September 14, 2026 14:12
e02da0d to
4f800d4
Compare
charliermarsh
added this pull request to stack #28576
September 14, 2026 14:12
carljm
added a commit
that referenced
this pull request
Sep 14, 2026
…aliases * origin/main: (21 commits) [ty] Share attribute write compatibility checks (#28555) [ty] Prefer `ty.toml` and `pyproject.toml` over playground `ty.json` (#28449) [`ruff`, `flake8-use-pathlib`] Support `parent_mode` (`RUF064`, `PTH103`) (#28528) [`pyupgrade`] Make the fix for `UP040` always unsafe (#28526) [`pyupgrade`] Skip `TypeVarTuple` and `ParamSpec` conversions with bounds or constraints (`UP040`, `UP046`, `UP047`) (#28505) [ty] Escape glob characters in anchored directory paths (#28518) [ty] Handle gradual metaclass ancestry and conflicts (#28474) [ty] Preserve recursive metadata in union transformations (#28497) [ty] Refactor "desperate" import resolution to use candidate operations that will also apply to module enumeration. (#28543) [ty] Report override conflicts introduced by new bases (#28530) [ty] Resolve dependencies within correlated inference alternatives (#28252) [ty] Extract shared abstract-method analysis (#28537) [ty] Reject reassignment of enum members (#28462) [ty] Preserve runtime comparison semantics when narrowing tagged unions (#28053) [ty] Extract a method on `NameResolver` to advance resolution by single module name component. (#28540) [ty] Return root discovery to `NameResolver`, but retain necessary interface changes (#28536) [ty] Default-specialize class objects in meta-protocol checks (#28265) [ty] Extract module root discovery from `NameResolver`. (#28531) [ty] Fix MRO ordering for generic bases (#28172) [ty] Run benchmarks for auto-imports in CI (#28490) ... # Conflicts: # crates/ty_python_semantic/src/types/narrow.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We move attribute-write compatibility checking from
protocol_class.rstoattribute_write.rs, alongside the lookup and descriptor-setter helpers it uses. This makes the same write checks available to nominal attribute override validation.Protocol checking continues to use the active type relation and constraints. Descriptor setters,
Selfbinding, class and instance fallbacks, and terminal__setattr__behavior are unchanged.Part of astral-sh/ty#2158.