Repository navigation
Conversation
8d81283 to
4c9c3ce
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
4c9c3ce to
25e5e1b
Compare
25e5e1b to
1e99af1
Compare
1e99af1 to
0d8544a
Compare
| assert_eq!( | ||
| response, | ||
| json!({ | ||
| "id": "MAL-2026-1234", | ||
| "modified": "2026-01-01T00:00:00Z", | ||
| }) |
There was a problem hiding this comment.
[P3] Remove the unit test that only echoes fixture JSON
This test verifies that Wiremock returns the static JSON supplied to set_body_json, including the arbitrary timestamp. None of the three migrated commands consumes this GET response: check_malware_dependencies calls Osv::query_identifiers, which only requests /querybatch. The test therefore adds fixture data to maintain without exercising the behavior supported by this refactor. Remove it and rely on the existing add_malware_detected, run_malware_detected, and sync_malware_detected snapshots, which exercise the shared batch response through uv's client.
894cf69 to
5240fa8
Compare
5240fa8 to
1462a0c
Compare
Move the repeated OSV querybatch and advisory responses into a small
uv-testhelper, following the request in astral-sh#18936. The malware-detection tests foruv add,uv run, anduv syncnow share the same fixtures while retaining their existing setup order. Specialized authentication, request-count, and failure mocks remain explicit.