Skip to content

Format UnnamedRequirement extras directly - #1360

Draft
zaniebot wants to merge 1 commit into
mainfrom
zb/maint-format-unnamed-requirement-extras
Draft

zaniebot wants to merge 1 commit into
mainfrom
zb/maint-format-unnamed-requirement-extras

Conversation

@zaniebot

Copy link
Copy Markdown
Collaborator

UnnamedRequirement still builds a temporary Vec<String> to render extras. Format the stored extras directly with Itertools::format, matching named requirements while preserving their order, duplicates, and existing URL and marker rendering. This follows the direct-formatting cleanup in astral-sh#20206.

@astral-automations-bot astral-automations-bot Bot added the internal A refactor or improvement that is not user-facing label Sep 10, 2026
@zaniebot zaniebot added risk:1 Negligible risk of localized mistakes that are obvious and easy to correct. priority:3 Normal: useful features, documentation, usability, or routine efficiency improvements. size:1 Small: one localized behavior with straightforward tests or documentation checks. labels Sep 11, 2026
@zaniebot
zaniebot force-pushed the zb/maint-format-unnamed-requirement-extras branch from 49d2c51 to 72af449 Compare September 14, 2026 02:48
@codspeed

codspeed Bot commented Sep 14, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 25 untouched benchmarks


Comparing zb/maint-format-unnamed-requirement-extras (72af449) with main (c0df400)

Open in CodSpeed

@zaniebot zaniebot added the project:maintainer-followups Maintainer follow-up work label Oct 9, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user-facing priority:3 Normal: useful features, documentation, usability, or routine efficiency improvements. project:maintainer-followups Maintainer follow-up work risk:1 Negligible risk of localized mistakes that are obvious and easy to correct. size:1 Small: one localized behavior with straightforward tests or documentation checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants