Skip to content

Validate locked editable workspace sources - #211

Draft
zaniebot wants to merge 1 commit into
mainfrom
zb/bughunt200/139-editable-root-lock-source
Draft

zaniebot wants to merge 1 commit into
mainfrom
zb/bughunt200/139-editable-root-lock-source

Conversation

@zaniebot

@zaniebot zaniebot commented Jul 16, 2026 •

Copy link
Copy Markdown
Collaborator

An edited lockfile can replace an editable workspace root with another project that declares the same metadata. Locked validation still accepts it and installs the replacement. Instead, validate the editable source against the workspace. This only checks workspace identity; paths that resolve through symlinks may still be distinguished, and --frozen continues to bypass validation. Editable revalidation for script locks was fixed separately in uv#18328 for uv#18312.

@zaniebot
zaniebot force-pushed the zb/bughunt200/139-editable-root-lock-source branch from a72c736 to 229814a Compare July 16, 2026 02:38
@zaniebot zaniebot added priority:2 Important: bounded correctness, release reliability, committed work, or proven performance gains. size:3 Substantial: interacting behaviors, difficult compatibility questions, or a careful migration. bug Something isn't working security risk:3 Credible risk of meaningful incorrect behavior or regression; bounded or recoverable. labels Sep 9, 2026
@astral-automations-bot
astral-automations-bot Bot force-pushed the zb/bughunt200/139-editable-root-lock-source branch from 229814a to c2a6e04 Compare September 16, 2026 13:16
@codspeed

codspeed Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by ×9.4

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 11 improved benchmarks
✅ 43 untouched benchmarks
⏩ 35 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ WallTime unzip_wheel_many_files 371 ms 12.1 ms ×31
⚡ WallTime install_wheel_many_files 385 ms 13.5 ms ×28
⚡ WallTime prepare_wheel_many_files 383.4 ms 14.5 ms ×26
⚡ WallTime unpack_sdist_many_files 317.2 ms 36.2 ms ×8.8
⚡ WallTime resolve_warm_jupyter_universal 87.6 ms 11.6 ms ×7.6
⚡ WallTime resolve_warm_jupyter 17.4 ms 2.4 ms ×7.2
⚡ WallTime discover_workspace_from_all_members_with_excludes 52.7 ms 8.1 ms ×6.5
⚡ WallTime discover_workspace_from_all_members 50.5 ms 7.7 ms ×6.5
⚡ WallTime run_python_version_synthetic_workspace 268.4 ms 42.6 ms ×6.3
⚡ WallTime resolve_warm_airflow 233.2 ms 41.3 ms ×5.6
⚡ WallTime hash_sha256 1,165.6 µs 402.5 µs ×2.9

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing zb/bughunt200/139-editable-root-lock-source (b8f62a3) with main (b7c8c62)2

Open in CodSpeed

Footnotes

  1. 35 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (00e49e7) during the generation of this report, so b7c8c62 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@zaniebot zaniebot added priority:1 High: material security boundary, data loss, silent incorrect results, or major regression. and removed priority:2 Important: bounded correctness, release reliability, committed work, or proven performance gains. labels Sep 27, 2026
@astral-automations-bot
astral-automations-bot Bot force-pushed the zb/bughunt200/139-editable-root-lock-source branch from c2a6e04 to b8f62a3 Compare October 8, 2026 00:01

This branch was successfully deployed

1 active deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority:1 High: material security boundary, data loss, silent incorrect results, or major regression. risk:3 Credible risk of meaningful incorrect behavior or regression; bounded or recoverable. security size:3 Substantial: interacting behaviors, difficult compatibility questions, or a careful migration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants