Skip to content

Benchmark universal conflict marker operations - #2147

Draft
zaniebot wants to merge 3 commits into
zb/index-marker-dnffrom
zb/bench-universal-conflict-markers
Draft

zaniebot wants to merge 3 commits into
zb/index-marker-dnffrom
zb/bench-universal-conflict-markers

Conversation

@zaniebot

Copy link
Copy Markdown
Collaborator

Large conflict sets affect both lockfile marker construction and activated-extra resolution during export. Add focused benchmarks for UniversalMarker::imbibe and resolve_activated_extras, including the expanded markers found in existing lockfiles. Run the cases in CodSpeed simulation and walltime mode. Stacks on #2140.

@astral-automations-bot astral-automations-bot Bot added area:benchmarks Related to benchmarking internal A refactor or improvement that is not user-facing labels Sep 29, 2026
@codspeed

codspeed Bot commented Sep 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 84 untouched benchmarks
🆕 12 new benchmarks
⏩ 16 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
🆕 WallTime imbibe_and_format[16] N/A 888.3 µs N/A
🆕 WallTime imbibe_and_format[32] N/A 18.4 ms N/A
🆕 WallTime imbibe_and_format[4] N/A 19.1 µs N/A
🆕 WallTime resolve_activated_extras[16] N/A 1.1 ms N/A
🆕 WallTime resolve_activated_extras[32] N/A 19.7 ms N/A
🆕 WallTime resolve_activated_extras[4] N/A 27.9 µs N/A
🆕 Simulation imbibe_and_format[16] N/A 3.7 ms N/A
🆕 Simulation imbibe_and_format[32] N/A 82 ms N/A
🆕 Simulation imbibe_and_format[4] N/A 104.3 µs N/A
🆕 Simulation resolve_activated_extras[16] N/A 4.3 ms N/A
🆕 Simulation resolve_activated_extras[32] N/A 84.4 ms N/A
🆕 Simulation resolve_activated_extras[4] N/A 131.8 µs N/A

Comparing zb/bench-universal-conflict-markers (7c5b215) with zb/index-marker-dnf (bb74dfc)

Open in CodSpeed

Footnotes

  1. 16 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@zaniebot
zaniebot added this pull request to stack #2155 September 29, 2026 22:34
@zaniebot zaniebot added risk:1 Negligible risk of localized mistakes that are obvious and easy to correct. priority:3 Normal: useful features, documentation, usability, or routine efficiency improvements. size:2 Moderate: one subsystem with meaningful invariants, edge cases, or operational evidence to inspect. labels Sep 30, 2026
@zaniebot zaniebot added the build:skip-release Disable building release binaries for a pull request label Oct 7, 2026
@zaniebot
zaniebot removed this pull request from stack #2155 October 7, 2026 23:37
@zaniebot
zaniebot added this pull request to stack #2337 October 7, 2026 23:38
@zaniebot
zaniebot removed this pull request from stack #2337 October 8, 2026 00:02
@zaniebot
zaniebot added this pull request to stack #2339 October 8, 2026 00:02
@zaniebot
zaniebot removed this pull request from stack #2339 October 8, 2026 00:19
@zaniebot
zaniebot added this pull request to stack #2340 October 8, 2026 00:19

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:benchmarks Related to benchmarking build:skip-release Disable building release binaries for a pull request internal A refactor or improvement that is not user-facing priority:3 Normal: useful features, documentation, usability, or routine efficiency improvements. risk:1 Negligible risk of localized mistakes that are obvious and easy to correct. size:2 Moderate: one subsystem with meaningful invariants, edge cases, or operational evidence to inspect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants