Skip to content

Revert interpreter cache warming - #2615

Closed
zaniebot wants to merge 3 commits into
mainfrom
zb/revert-interpreter-cache-warming
Closed

zaniebot wants to merge 3 commits into
mainfrom
zb/revert-interpreter-cache-warming

Conversation

@zaniebot

@zaniebot zaniebot commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Interpreter cache warming can infer sys._base_executable incorrectly when the base interpreter is a symlink, as reported in astral-sh#22383. Revert astral-sh#21304 so newly created environments query Python on their next use.

I avoid bumping the cache bucket here as it seems excessive given the scope of the impact.

This reverts commit c09b4a5.

Bump the interpreter cache version to invalidate metadata inferred during virtual environment creation.
@astral-automations-bot astral-automations-bot Bot added the bug Something isn't working label Oct 13, 2026
@zaniebot
zaniebot force-pushed the zb/revert-interpreter-cache-warming branch from 5463768 to 180e2b5 Compare October 13, 2026 16:59
@zaniebot
zaniebot deployed to automations October 13, 2026 17:01 — with GitHub Actions Active
@zaniebot
zaniebot deployed to automations October 13, 2026 17:20 — with GitHub Actions Active
@zanieb
zanieb marked this pull request as ready for review October 13, 2026 17:30
@astral-automations-bot

Copy link
Copy Markdown

Promoted to #22520.

@codspeed

codspeed Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ 8 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

✅ 54 untouched benchmarks
⏩ 35 skipped benchmarks1


Comparing zb/revert-interpreter-cache-warming (8137cfd) with main (42ef32b)

Open in CodSpeed

Footnotes

  1. 35 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

This branch was successfully deployed

1 active deployment
automations — 8137cfd0 Deployed Oct 13, 2026 by zaniebot via review-code-quality / code quality review #9706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant