Skip to content

Retain SafeUrl policies when removing credentials - #2779

Closed
zaniebot wants to merge 1 commit into
zaniebot/safe-url-parser-20261015from
zaniebot/safe-url-without-credentials-20261015
Closed

zaniebot wants to merge 1 commit into
zaniebot/safe-url-parser-20261015from
zaniebot/safe-url-without-credentials-20261015

Conversation

@zaniebot

Copy link
Copy Markdown
Collaborator

Return Cow<SafeUrl<P>> from without_credentials() so removing sensitive userinfo retains the serialization policy and redacted formatting. Serialization and archive metadata retain complete query strings, and keyring URL targets use explicit string access.

Stacked on astral-sh#22612.

@zaniebot
zaniebot deployed to automations October 15, 2026 20:59 — with GitHub Actions Active
@astral-automations-bot astral-automations-bot Bot added bug Something isn't working security labels Oct 15, 2026
@zanieb
zanieb marked this pull request as ready for review October 15, 2026 21:02
@astral-automations-bot

Copy link
Copy Markdown

Promoted to #22617.

@codspeed

codspeed Bot commented Oct 15, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 14.69%

⚠️ 8 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 68 untouched benchmarks
⏩ 35 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ ⚠️ Simulation discover_workspace_from_all_members_with_excludes 139.8 ms 163.8 ms -14.69%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing zaniebot/safe-url-without-credentials-20261015 (67cb415) with zaniebot/safe-url-parser-20261015 (9cba159)

Open in CodSpeed

Footnotes

  1. 35 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

This branch was successfully deployed

1 active deployment
automations — 67cb4159 Deployed Oct 15, 2026 by zaniebot via review-code-quality / code quality review #10447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants