Repository navigation
Preserve repository-relative Git archive paths during sync - #826
Closed
astral-automations-bot[bot] wants to merge 2 commits into
Closed
astral-automations-bot[bot] wants to merge 2 commits into
astral-automations-bot[bot] wants to merge 2 commits into
Conversation
zanie-oai
reviewed
Aug 20, 2026
zaniebot
force-pushed
the
automations/fix-bug/21244
branch
from
August 20, 2026 19:36
d14440a to
da3eca3
Compare
zanieb
marked this pull request as ready for review
August 21, 2026 13:22
Author
|
Promoted to #21264. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh
uv synccan look for a Git-hosted archive in the downstream project instead of the Git checkout, even though retrying with the written lockfile succeeds.Source history traces this to astral-sh#10072: it introduced repository-relative
GitPathBuiltDist::install_pathandGitPathSourceDist::install_path, but their lock constructors appliedrelative_toagainst the workspace root and fell back tostd::path::absolute.locked_git_urlretained the original relative path, so the serialized lock was correct while the in-memoryGitSource.pathused by the first sync was not. The direct-archive tests locked before installing. Later, astral-sh#19589 preserved Git identity when lowering generated metadata that references an archive in the same checkout, but its regression only inspected the lockfile. Neither exercised installation from the newly constructed in-memory lock.Preserve the repository-relative path in both Git archive lock constructors and use it consistently for
locked_git_urlandGitSource.path. The installer then resolves the archive inside the fetched Git checkout, so fresh sync and lockfile replay use the same path.Fixes astral-sh#21244.