Error when tool.uv.sources is set in system-level configuration file

[charliermarsh]

Summary

I think the lack of enforcement here is an oversight. We do already enforce this for user-level configuration files (contrary to the issue -- at least, in my testing and from reading the code).

Closes #12753.

[orishamir]

Hey, thank you so much for working on this! Your thoughtfulness and how much you care is incredible and highly appreciated
You mentioned user-level configuration is enforced, and after testing, I realized I misplaced uv.toml while testing user-level.
So you're correct

FROM python:3.12-slim-bookworm
COPY --from=ghcr.io/astral-sh/uv:latest /uv /uvx /bin/

WORKDIR /app

RUN uv init

COPY <<EOF /root/.config/uv/uv.toml
[sources]
doesntmatter = { index = "doesnt_matter"}
EOF

CMD ["uv", "sync"]

Errors as it should

[orishamir]

Would you like me to edit the original issue? or add a note?

[zanieb]

Wasn't this intentional? Since the system-level configuration could be shared by multiple uv versions we wanted to avoid validating it?

[zanieb]

I don't see commentary about it in #7851

[charliermarsh]

Wasn't this intentional? Since the system-level configuration could be shared by multiple uv versions we wanted to avoid validating it?

Can you explain what you mean by "avoid validating it"? We validate it each way, it's just that at present, we don't error if you include fields that we'll ultimately ignore. (Also, is this different than user-level configuration?)

[zanieb]

Also, is this different than user-level configuration?

Yeah my understanding was we would expect a user to control their own uv config but at the system level erroring on unknown fields could be problematic since it's administered by someone else and needs broader compatibility.

It sounds like my understanding is wrong though, and we always error on unknown fields in settings files? I looked at validate_uv_toml and it just validates that we're not silently ignoring known fields that aren't supported in this file — that's fine with me.

[charliermarsh]

👍 Agreed, makes sense.