Fix VIRTUAL_ENV_PROMPT value in activator/activate #13501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've compared all the activator scripts here with the original ones in https://github.com/pypa/virtualenv/tree/main/src/virtualenv/activation and only the bash/POSIX script here was yielding a VIRTUAL_ENV_PROMPT value with parenthesis and a trailing space, which should be part of the shell prompt (PS1 for bash/POSIX) but not of the VIRTUAL_ENV_PROMPT value itself. This fixes that small inconsistency. Fixes #13456 This reverts commit 0ec2d4e
Member
|
I tend to agree with this change. |
charliermarsh
added
the
compatibility
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
May 20, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.7.5` -> `0.7.6` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.7.6`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#076) [Compare Source](astral-sh/uv@0.7.5...0.7.6) ##### Python - Add Python 3.14 on musl - Add free-threaded Python on musl - Add Python 3.14.0a7 - Statically link `libpython` into the interpreter on Linux for a significant performance boost See the [`python-build-standalone` release notes](https://github.com/astral-sh/python-build-standalone/releases/tag/20250517) for more details. ##### Enhancements - Improve compatibility of `VIRTUAL_ENV_PROMPT` value ([#​13501](astral-sh/uv#13501)) - Bump MSRV to 1.85 and Edition 2024 ([#​13516](astral-sh/uv#13516)) ##### Bug fixes - Respect default extras in uv remove ([#​13380](astral-sh/uv#13380)) ##### Documentation - Fix PowerShell code blocks ([#​13511](astral-sh/uv#13511)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4xNS4wIiwidXBkYXRlZEluVmVyIjoiNDAuMTUuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
ericbn
added a commit
to zimfw/eriner
that referenced
this pull request
May 21, 2025
This was fixed in uv 0.7.6. See https://github.com/astral-sh/uv/releases/tag/0.7.6 and astral-sh/uv#13501
ericbn
added a commit
to zimfw/agnoster
that referenced
this pull request
May 21, 2025
This was fixed in uv 0.7.6. See https://github.com/astral-sh/uv/releases/tag/0.7.6 and astral-sh/uv#13501
ericbn
added a commit
to zimfw/agnoster
that referenced
this pull request
May 21, 2025
This was fixed in uv 0.7.6. See https://github.com/astral-sh/uv/releases/tag/0.7.6 and astral-sh/uv#13501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've compared all the activator scripts here with the original ones in https://github.com/pypa/virtualenv/tree/main/src/virtualenv/activation and only the bash/POSIX script here was yielding a VIRTUAL_ENV_PROMPT value with parenthesis and a trailing space, which should be part of the shell prompt (PS1 for bash/POSIX) but not of the VIRTUAL_ENV_PROMPT value itself. This fixes that small inconsistency. Fixes #13456
This reverts commit 0ec2d4e
Test Plan
I didn't test this locally.