-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Require uv venv --clear before removing an existing directory
#14309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f93f6e3
Require `uv venv --clear` before clearing an existing directory
jtfmumm adcbeac
Use `VenvCreationPolicy` instead of clear and allow-existing bools
jtfmumm 30efb61
Warn on existing directory if not tty
jtfmumm f07d45a
Review
jtfmumm 2776aed
..
jtfmumm 00e67ef
..
jtfmumm 2ec7db3
nit: move empty directory case into match
zanieb a7a1389
nit: simplify variable message
zanieb dc49fe3
use match for is_file / is_dir and handle case where neither is true
zanieb 2b49ecc
return an `Option` from `confirm_clear` to avoid duplicated tty check
zanieb 49c1d34
use templated name in more places
zanieb cba1670
Rename the creation policy to `OnExisting`
zanieb 983b42b
nit: include reason in removing log to match others
zanieb 6befef3
Update snapshot
zanieb d08a162
Add a hint to the prompt
zanieb 8f991bb
Use qualified name for `OnExisting` for clarity
zanieb 8df25a1
Use "replace it" language consistently
zanieb 5548b6e
Fix prompt cleanup
zanieb 6926995
Tweak prompt language
zanieb 557604e
Update the error hint to match the prompt hint
zanieb 4d7633c
Merge branch 'release/080' into jtfm/venv-clear
zanieb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good example of the breakage we'd cause with this change. I wonder if we can craft a GitHub search that captures if a second
uv venvis common?