-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Defer stabilization of the uv python install --default behavior
#14681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7ee2a85 to
9d2c457
Compare
9d2c457 to
988ecb9
Compare
| // TODO(zanieb): We want more feedback on the `is_default_install` behavior before stabilizing | ||
| // it. In particular, it may be confusing because it does not apply when versions are loaded | ||
| // from a `.python-version` file. | ||
| let targets = if (default || (is_default_install && preview.is_enabled())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could stabilize the is_default_install behavior (i.e., uv python install gets you python / python3 / python3.13 while uv python install 3.13 only gets you python3.13) separately from the --default flag. The default install behavior is really helpful for beginners, who expect uv python install to result in an available python executable, but I'm not sure how common it is for people to run it without a version request.
| // installed with the `--default` flag. | ||
| if default && !preview.is_enabled() { | ||
| warn_user!( | ||
| "The `--default` option is experimental and may change without warning. Pass `--preview` to disable this warning" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this is supposed to end in a period since it's multiple sentences, but not sure if we do that consistently for these preview warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we do. I can do a pass for that everywhere separately.
I'm a little worried about the semantics of this flag and the "default install". We can make it more accessible while stabilizing the rest of the behaviors, while deferring final stabilization of this to a future release. I left some TODOs in the code covering open questions for the feature.
This is stacked on #14626, which initially stabilized this feature.