Skip to content

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Jul 17, 2025

I'm a little worried about the semantics of this flag and the "default install". We can make it more accessible while stabilizing the rest of the behaviors, while deferring final stabilization of this to a future release. I left some TODOs in the code covering open questions for the feature.

This is stacked on #14626, which initially stabilized this feature.

@zanieb zanieb force-pushed the zb/no-stable-default branch from 7ee2a85 to 9d2c457 Compare July 17, 2025 13:06
@zanieb zanieb force-pushed the zb/no-stable-default branch from 9d2c457 to 988ecb9 Compare July 17, 2025 13:08
Comment on lines +742 to +745
// TODO(zanieb): We want more feedback on the `is_default_install` behavior before stabilizing
// it. In particular, it may be confusing because it does not apply when versions are loaded
// from a `.python-version` file.
let targets = if (default || (is_default_install && preview.is_enabled()))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could stabilize the is_default_install behavior (i.e., uv python install gets you python / python3 / python3.13 while uv python install 3.13 only gets you python3.13) separately from the --default flag. The default install behavior is really helpful for beginners, who expect uv python install to result in an available python executable, but I'm not sure how common it is for people to run it without a version request.

@zanieb zanieb marked this pull request as ready for review July 17, 2025 13:15
@zanieb zanieb temporarily deployed to uv-test-registries July 17, 2025 13:15 — with GitHub Actions Inactive
// installed with the `--default` flag.
if default && !preview.is_enabled() {
warn_user!(
"The `--default` option is experimental and may change without warning. Pass `--preview` to disable this warning"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is supposed to end in a period since it's multiple sentences, but not sure if we do that consistently for these preview warnings.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we do. I can do a pass for that everywhere separately.

@zanieb zanieb merged commit 77bde0f into zb/stable-bin Jul 17, 2025
91 of 92 checks passed
@zanieb zanieb deleted the zb/no-stable-default branch July 17, 2025 13:29
zanieb added a commit that referenced this pull request Jul 17, 2025
Closes #14296

As mentioned in #14681, this does not stabilize the `--default`
behavior.
zanieb added a commit that referenced this pull request Jul 17, 2025
Closes #14296

As mentioned in #14681, this does not stabilize the `--default`
behavior.
zanieb added a commit that referenced this pull request Jul 17, 2025
Closes #14296

As mentioned in #14681, this does not stabilize the `--default`
behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants