Revert "Use an ephemeral environment for uv run --with invocations (#14447)"
#14788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
This was referenced Jul 21, 2025
zanieb
added a commit
that referenced
this pull request
Jul 22, 2025
…ments (#14790) This is an alternative to #14788 which has the benefit that it addresses #13327 which would be an issue even if we reverted #14447. There are two changes here 1. We copy entry points into the ephemeral environment, and rewrite their shebangs (or trampoline target) to ensure the ephemeral environment is not bypassed. 2. We link `etc/jupyter` and `share/jupyter` data directories into the ephemeral environment, this is in order to ensure the above doesn't break Jupyter which unfortunately cannot find the `share` directory otherwise. I'd love not to do this, as it seems brittle and we don't have a motivating use-case beyond Jupyter. I've opened jupyterlab/jupyterlab#17716 upstream for discussion, as there is a viable patch that could be made upstream to resolve the problem. I've limited the fix to Jupyter directories so we can remove it without breakage. Closes #14729 Closes #13327 Closes #14749 --------- Co-authored-by: Charlie Marsh <[email protected]>
Member
|
Hopefully not needed, but still viable following #14790 if we need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reverts commit 6df7dab, which is causing more trouble than it is solving problems. Specifically, for tools like Jupyter and MyPy, because the shebang in the script of the
--withenvironment uses the Python of the--withenvironment (and that environment does not have the requisite.pthfile), they're not able to see any of the base environment's dependencies. We considered copying over those executables and rewriting the shebangs, and that could work for MyPy, but it ends up breaking Jupyter:Closes #14749.
Closes #14729.