Repository navigation
Conversation
43d4aaf to
313b371
Compare
|
Can you add a test for this in |
|
Should be ready now @konstin, the release binary tests appear to be failing, but unrelated. |
|
More interesting failures |
|
Those are from a GitHub outage earlier. I'll requeue those. |
|
Looks like one error persists, the sdist build is attempting to build with an outdated version of Rust. |
Yeah, you'll need to rebase or merge main for that one: #19131 |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@apaz-cli Please don't send us repeated pings to review; we review all PRs that come in as we're able. |
|
fair enough, I will fork for now |
|
It's been over a month, please review or close :) |
|
Time permitting, I will review this week. |
|
ty :) |
|
I'll just note here to set expectations for when contributing to an open source project in general that the equivalent PR for pip had to wait 5 months for reviews to begin in earnest and 7 months to merge: pypa/pip#12991 Pinging maintainers can be helpful to make sure something isn't forgotten, but part of contributing to projects usually involves some patience on the timescale of months, not days. |
woodruffw
left a comment
There was a problem hiding this comment.
I'll take over the remainder of this PR. Some initial review below.
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
uv test inventory changesThis PR changes the tests when compared with the latest
|
| /// A valid wheel whose data descriptors require the on-disk extraction fallback. | ||
| async fn wheel_requiring_download() -> Vec<u8> { |
There was a problem hiding this comment.
Noting: I'm not in love this this test fixture, since it relies on a piece of unrelated weirdness/implicit state (the fact that the default writer from async-zip uses data descriptors).
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
|
The state machine is a little hard to follow here, so here's my attempt to map it out:
In effect this means that we'll use the retry machinery on pretty much every failure, except the subset of failures that we know correspond to a partial copy. When that occurs we'll entry our retry-independent loop, which should generally only execute once (either resuming the download to completion, or booting back to retry). |
|
Status on this? |
|
I'm continuing this in #21570, since the current branch is pretty far behind. My hope is we can land some version of this soon, but I need to be more confident that I understand the retry/resume state machine (especially around misbehaving origins, partial resumptions, etc.). |
Summary
For whatever reason, pypi resets the connection a lot, and we run out of retries.
pipdoes not have this problem because it retries with http Range requests, and does not have to redownload the whole file.I have been plagued with this issue for about a year, and it has made uv near-unusable for me, unless I am using an index other than official pypi. When I use uv I usually have to use the Tsinghua mirror, because pypi is flaky and uv cannot handle it.
I've gotten so frustrated with uv recently that I decided to take matters into my own hands.
It looks like someone else tried to address this in #17656, but that PR was rejected for being complicated, and the author never followed up. There have been other attempts too, if I recall.
Fixes #16934
Fixes #13359
Fixes #18642
Fixes #18538
Testing
Passed all tests in:
Except for
python_upgrade::python_upgrade_implementation, which appears to be broken on main.