Skip to content

Remove Cow representation tests for shell escaping - #20213

Merged
zanieb merged 1 commit into
astral-sh:mainfrom
zaniebot:zb/remove-shell-cow-representation-tests
Jul 7, 2026
Merged

zanieb merged 1 commit into
astral-sh:mainfrom
zaniebot:zb/remove-shell-cow-representation-tests

Conversation

@zaniebot

@zaniebot zaniebot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Removes tests added in #20196 that assert whether shell escaping returns a borrowed or owned value. Borrowing is an implementation detail here, while the existing output-oriented tests continue to cover escaping behavior.

@zanieb zanieb added internal A refactor or improvement that is not user-facing performance and removed internal A refactor or improvement that is not user-facing labels Jul 7, 2026
@zanieb
zanieb marked this pull request as ready for review July 7, 2026 17:05
@zanieb
zanieb enabled auto-merge (squash) July 7, 2026 17:05
@zanieb zanieb added internal A refactor or improvement that is not user-facing and removed performance labels Jul 7, 2026
@zanieb
zanieb merged commit b31a86f into astral-sh:main Jul 7, 2026
57 checks passed
@zanieb zanieb added performance and removed internal A refactor or improvement that is not user-facing labels Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants