Repository navigation
Resolve venv base executables independently of cached metadata - #22508
Draft
konsti-openai wants to merge 2 commits into
Draft
konsti-openai wants to merge 2 commits into
konsti-openai wants to merge 2 commits into
Conversation
konsti-openai
temporarily deployed
to
automations
October 13, 2026 12:14 — with
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
Remove sys._base_executable from interpreter discovery and caching. Resolve base paths from environment configuration, executable links, and public interpreter metadata when needed, before replacing a source environment. Keep cache warming and selected aliases, invalidate the old cache format, and add a regression test for cached discovery through executable symlinks. Fixes #22383.
zanieb
changed the base branch from
main
to
zb/restore-interpreter-cache-warming
October 13, 2026 19:01
zanieb
force-pushed
the
konsti/venv-cache-recorded-base
branch
from
October 13, 2026 19:01
46586ec to
476f403
Compare
woodruffw
reviewed
Oct 14, 2026
| Self::FlatIndex => "flat-index-v6", | ||
| Self::Git => "git-v1", | ||
| Self::Interpreter => "interpreter-v4", | ||
| Self::Interpreter => "interpreter-v6", |
Member
There was a problem hiding this comment.
Just noting we're going v4->v6 here 🙂
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a venv from a symlinked Python executable can cache a different base path from the one CPython later reports through
sys._base_executable. Cached and freshly queried environments can then disagree, and repairing an executable link can leave child venvs using a stale path.Remove production reliance on this private attribute. Resolve the base executable when needed from
pyvenv.cfgand executable links, using public interpreter metadata to check copied executables. Record uv's choice asuv-base-executable, retain valid aliases, and resolve the base before replacing its source environment. Cache warming remains enabled, and the interpreter cache format is bumped.Fixes #22383.
Stacked on #22524.