Repository navigation
Select wheel variants without required properties - #22535
Conversation
67accb0 to
5251cf2
Compare
Merging this PR will not alter performance2 warnings
Comparing Footnotes
|
3665e2d to
5566b42
Compare
5566b42 to
3b4589a
Compare
3b4589a to
a3fb5d3
Compare
12860ea to
dcf9b78
Compare
dcf9b78 to
969d516
Compare
969d516 to
1eff8eb
Compare
fbe4dc8 to
bf1b253
Compare
bf1b253 to
c35364b
Compare
c35364b to
92f8570
Compare
92f8570 to
afbb230
Compare
afbb230 to
f2b8da5
Compare
f2b8da5 to
f769ca5
Compare
uv test inventory changesThis PR changes the tests when compared with the
|
| // Select a variant only for a specific environment and an installable candidate. | ||
| // TODO(konsti): Check variant compatibility before reusing an installed candidate. | ||
| let variant = if env.marker_environment().is_some() | ||
| && uv_preview::is_enabled(PreviewFeature::WheelVariants) | ||
| && let Some(prioritized) = candidate.prioritized() | ||
| { | ||
| self.select_wheel_variant(candidate.version(), prioritized, version_maps, requests)? |
There was a problem hiding this comment.
what should happen when a variant wheel is older than an --exclude-newer cutoff, but a regular wheel is newer?
There was a problem hiding this comment.
Added this as a TODO in #22043, ideally that's too much of an edge case to run into it at all but we should bring it at least to the level we already support before stabilization.
Use index-level variant metadata to select wheels whose variant requires no properties, including the null variant. With
wheel-variantsenabled, these wheels are preferred over ordinary wheels after checking their platform tags and hashes.Variant wheels requiring properties remain incompatible. Selection currently requires index-level variant metadata and applies to platform-specific resolutions; direct wheel URLs and universal lockfiles do not yet support variants.
Stacked on #22512.