Skip to content

Use bitsets for all DNF simplification - #22613

Closed
charliermarsh wants to merge 2 commits into
charlie/marker-dnf-candidatesfrom
charlie/marker-dnf-interned
Closed

charliermarsh wants to merge 2 commits into
charlie/marker-dnf-candidatesfrom
charlie/marker-dnf-interned

Always compare DNF clauses with bitsets

cc52b9c
Select commit
Loading
Failed to load commit list.
CodSpeed / CodSpeed Performance Analysis failed Oct 16, 2026 in 0s

8 benchmarks regressed

⚠️ 8 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 10 improved benchmarks
❌ 8 regressed benchmarks
✅ 101 untouched benchmarks
⏩ 104 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ WallTime marker_to_dnf_two_clauses 476 ns 584 ns -18.49%
❌ Simulation marker_to_dnf_two_clauses 34.4 µs 42 µs -18.16%
❌ Simulation marker_to_dnf_platform_specific_python_versions 43.5 µs 51.6 µs -15.63%
❌ Simulation resolve_activated_extras_independent_pairs[2] 23.3 µs 27.4 µs -15.06%
❌ WallTime marker_to_dnf_platform_specific_python_versions 903 ns 1,021 ns -11.56%
❌ WallTime marker_to_dnf_sparse_clauses[512] 6.7 ms 7.2 ms -7.04%
❌ ⚠️ Simulation discover_workspace_from_all_members 132.2 ms 141.9 ms -6.81%
❌ Simulation imbibe_and_format_marker_conflict_dependent[4] 111.8 µs 118.6 µs -5.68%
⚡ Simulation imbibe_and_format_marker_conflict_dependent[16] 11 ms 7.9 ms +38.32%
⚡ WallTime imbibe_and_format_marker_conflict_dependent[16] 590.5 µs 457 µs +29.2%
⚡ Simulation marker_to_dnf_conflicting_extras[16] 3.2 ms 2.5 ms +28.56%
⚡ WallTime marker_to_dnf_conflicting_extras[4] 2.3 µs 1.9 µs +26.57%
⚡ WallTime marker_to_dnf_conflicting_extras[16] 175.9 µs 142.4 µs +23.49%
⚡ Simulation imbibe_marker_no_conflicts[0] 398.5 ns 343 ns +16.2%
⚡ Simulation marker_to_dnf_conflicting_extras[4] 74.3 µs 67.7 µs +9.79%
⚡ WallTime marker_to_dnf_conflicting_extras[32] 1.9 ms 1.8 ms +6.94%
⚡ WallTime imbibe_and_format_marker_conflict_dependent[32] 5.8 ms 5.4 ms +6.1%
⚡ Simulation marker_to_dnf_sparse_clauses[128] 5.8 ms 5.5 ms +5.13%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing charlie/marker-dnf-interned (cc52b9c) with charlie/marker-dnf-candidates (6e34068)

Open in CodSpeed

Footnotes

  1. 104 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩