Add job to test PyPy venv creation on Windows #5079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
force-pushed
the
test-pypy-windows
branch
from
fbde96a to
51555e2
Compare
Contributor
Author
|
I didn't expect a stack overflow. 😅 |
silvanocerza
force-pushed
the
test-pypy-windows
branch
from
51555e2 to
e8adbeb
Compare
Member
|
See https://github.com/astral-sh/uv/blob/main/CONTRIBUTING.md#testing-on-windows (which is handled in all of our Windows CI) |
Contributor
Author
|
That was easy, thanks. 🙏 I should have read the whole |
zanieb
reviewed
Jul 15, 2024
.github/workflows/ci.yml
Outdated
| - name: "Check version" | ||
| run: | | ||
| & .venv\Scripts\python --version |
Member
There was a problem hiding this comment.
Could you add a couple of these that invoke the non- "python" copies of the executable (and for Linux too)
zanieb
approved these changes
Jul 15, 2024
Member
|
Nice work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new job to test that PyPy venvs are correctly created on Windows and they contain all the expected binaries.
Test Plan
Just let CI run.