Skip to content

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Oct 22, 2024

With a change like #8458, we really need tests for these.

I'm just going to take the possible performance hit of these slow tests and deal with optimizing them separately.

@zanieb zanieb added the testing Internal testing of behavior label Oct 22, 2024
@zanieb zanieb force-pushed the zb/test-managed branch 2 times, most recently from 1a1e933 to f4ab884 Compare October 22, 2024 15:53
@zanieb
Copy link
Member Author

zanieb commented Oct 22, 2024

For context, these take ~7s on my machine and the free-threaded one makes the slow test list in Linux CI at 22s. I believe that one is slow because there's not an "install only" variant.

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trust you on this one.

@zanieb zanieb merged commit b713877 into main Oct 24, 2024
@zanieb zanieb deleted the zb/test-managed branch October 24, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Internal testing of behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants