Add support for default-groups
#8471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@zanieb -- We might need |
charliermarsh
force-pushed
the
charlie/default-groups
branch
4 times, most recently
from
084dfd5 to
8b864be
Compare
charliermarsh
added
the
enhancement
charliermarsh
commented
Oct 22, 2024
| pub(crate) spec: DevGroupsSpecification, | ||
| /// The default groups to include. | ||
| pub(crate) defaults: Vec<GroupName>, | ||
| } |
Member
Author
There was a problem hiding this comment.
I don't feel strongly on the name here, but this is the specification along with the project-specific defaults.
Member
|
Yeah I was imagining adding |
charliermarsh
commented
Oct 22, 2024
| /// Include dependencies from the specified groups. | ||
| Include(Vec<GroupName>), | ||
| /// Do not include dependencies from groups. | ||
| Exclude, |
Member
Author
There was a problem hiding this comment.
I made this the None case for groups: Option<GroupsSpecification>, to mirror dev: Option< DevMode>.
charliermarsh
force-pushed
the
charlie/default-groups
branch
from
8b864be to
df57bf3
Compare
zanieb
reviewed
Oct 22, 2024
zanieb
reviewed
Oct 22, 2024
charliermarsh
force-pushed
the
charlie/default-groups
branch
from
df57bf3 to
dfadcf9
Compare
charliermarsh
force-pushed
the
charlie/default-groups
branch
from
dfadcf9 to
d89dd18
Compare
zanieb
approved these changes
Oct 22, 2024
charliermarsh
force-pushed
the
charlie/default-groups
branch
from
d89dd18 to
5e17cab
Compare
Merged
charliermarsh
added a commit
that referenced
this pull request
Oct 23, 2024
## Summary This PR adds support for `tool.uv.default-groups`, which defaults to `["dev"]` for backwards-compatibility. These represent the groups we sync by default.
charliermarsh
added a commit
that referenced
this pull request
Oct 25, 2024
This PR adds support for `tool.uv.default-groups`, which defaults to `["dev"]` for backwards-compatibility. These represent the groups we sync by default.
charliermarsh
added a commit
that referenced
this pull request
Oct 25, 2024
This PR adds support for `tool.uv.default-groups`, which defaults to `["dev"]` for backwards-compatibility. These represent the groups we sync by default.
charliermarsh
added a commit
that referenced
this pull request
Oct 25, 2024
This PR adds support for `tool.uv.default-groups`, which defaults to `["dev"]` for backwards-compatibility. These represent the groups we sync by default.
zanieb
pushed a commit
that referenced
this pull request
Oct 25, 2024
This PR adds support for `tool.uv.default-groups`, which defaults to `["dev"]` for backwards-compatibility. These represent the groups we sync by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for
tool.uv.default-groups, which defaults to["dev"]for backwards-compatibility. These represent the groups we sync by default.