-
Notifications
You must be signed in to change notification settings - Fork 2.4k
✨ use UV_SYNC_ALL_EXTRAS env var in uv sync command #8541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f4e7d27 to
a5c3215
Compare
|
Just wondering, what's the use-case for this? |
|
Multiple |
|
Why are you making multiple invocations where |
|
I don't think the use cases are super solid. It's more like a nice to have feature. Imo ideally all CLI arguments should have corresponding env variables. Is your opinion different or you are just looking for clarification? This just make usage easier in some (probably rare) cases: doing multiple invocations with other arguments varying in docker/CI, controlling this behavior in CI pipelines without changing the CLI command (CI pipelines often pass env variables to each other), setting a development default for a project (what actually made me start this PR). The latter should really be a config parameter tho, but as a Rust newbee I decided to start from something more straightforward like an env variable. |
I think this is actually against our philosophy. I don't think every CLI argument should have a corresponding variable — only ones that configure something you'd commonly want to set as persistent state. It sounds more like your use-case here would be solved by a |
|
Understood, let me know if you still want this PR |
|
Would this be covered by #12965? |
|
I don't think so --- originally I needed this when building a docker image for a uv workspace with multiple internal extras. So I didn't want this to be a part of the global config, but rather a one time settings just for the docker image. |
Summary
uv syncCLI command now respectsUV_SYNC_ALL_EXTRASenvironment variable.Is can also add a config option if you think it makes sense to have one.