Remove Python executables on uninstall #8571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/python-exec-dir
branch
from
6bf47d0 to
2021ad8
Compare
zanieb
force-pushed
the
zb/python-exec-rm
branch
from
7b2c090 to
241e8ec
Compare
zanieb
added a commit
that referenced
this pull request
Oct 27, 2024
The shared arguments were resetting the `UV_PYTHON_INSTALL_DIR`, breaking the intent of the test. Added some uninstall tests too, needed later for #8571
zanieb
force-pushed
the
zb/python-exec-dir
branch
from
2021ad8 to
28b6613
Compare
zanieb
force-pushed
the
zb/python-exec-rm
branch
from
241e8ec to
da70b71
Compare
zanieb
added a commit
that referenced
this pull request
Oct 29, 2024
Following #8458, we need to remove the installed Python executables on `uv python uninstall`. Needs Windows support still, but that approach will be different since there won't be links.
zanieb
added a commit
that referenced
this pull request
Oct 29, 2024
Following #8458, we need to remove the installed Python executables on `uv python uninstall`. Needs Windows support still, but that approach will be different since there won't be links.
zanieb
added a commit
that referenced
this pull request
Oct 30, 2024
Following #8458, we need to remove the installed Python executables on `uv python uninstall`. Needs Windows support still, but that approach will be different since there won't be links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #8458, we need to remove the installed Python executables on
uv python uninstall.Needs Windows support still, but that approach will be different since there won't be links.