Use a + for the visual max local #8844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
the
internal
charliermarsh
force-pushed
the
charlie/version-small
branch
from
a7cfacf to
3e61e35
Compare
charliermarsh
force-pushed
the
charlie/plus
branch
from
9daaa4c to
b0ec5cc
Compare
charliermarsh
force-pushed
the
charlie/version-small
branch
from
3e61e35 to
2b92418
Compare
charliermarsh
force-pushed
the
charlie/plus
branch
from
b0ec5cc to
2e0d24e
Compare
charliermarsh
force-pushed
the
charlie/version-small
branch
from
2b92418 to
c9d1156
Compare
charliermarsh
force-pushed
the
charlie/plus
branch
from
2e0d24e to
0514ecf
Compare
charliermarsh
added a commit
that referenced
this pull request
Nov 6, 2024
## Summary We don't actually want users to see this, but we should be stripping it anyway. Without this change, we show ranges in the debug logs that look like `>=1.0.0, <1.0.0`, which is more confusing than helpful. (We may want to post-process those debug ranges to remove these.)
Merged
zanieb
pushed a commit
that referenced
this pull request
Nov 7, 2024
We don't actually want users to see this, but we should be stripping it anyway. Without this change, we show ranges in the debug logs that look like `>=1.0.0, <1.0.0`, which is more confusing than helpful. (We may want to post-process those debug ranges to remove these.)
zanieb
pushed a commit
that referenced
this pull request
Nov 7, 2024
We don't actually want users to see this, but we should be stripping it anyway. Without this change, we show ranges in the debug logs that look like `>=1.0.0, <1.0.0`, which is more confusing than helpful. (We may want to post-process those debug ranges to remove these.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We don't actually want users to see this, but we should be stripping it anyway. Without this change, we show ranges in the debug logs that look like
>=1.0.0, <1.0.0, which is more confusing than helpful. (We may want to post-process those debug ranges to remove these.)