Skip to content

Conversation

@mkniewallner
Copy link
Contributor

@mkniewallner mkniewallner commented Nov 9, 2024

Summary

As per #8943 (comment), adding a CI step to validate project metadata. Documentation for the tool: https://validate-pyproject.readthedocs.io/en/stable/readme.html. store is an extra that uses this package to get a weekly update of the schema in SchemaStore.

Test Plan

Step passes on CI, and testing the same command locally while voluntarily using a wrong classifier fails:

$ uvx --from 'validate-pyproject[all,store]' validate-pyproject pyproject.toml
Invalid file: pyproject.toml
[ERROR] `project.classifiers[5]` must be trove-classifier

@mkniewallner mkniewallner marked this pull request as ready for review November 9, 2024 14:25
@zanieb zanieb merged commit ecb3e98 into astral-sh:main Nov 9, 2024
64 checks passed
@zanieb zanieb added the testing Internal testing of behavior label Nov 9, 2024
@mkniewallner mkniewallner deleted the ci/validate-pyproject branch November 9, 2024 17:48
konstin pushed a commit that referenced this pull request Nov 10, 2024
## Summary

As per #8943 (comment),
adding a CI step to validate project metadata. Documentation for the
tool: https://validate-pyproject.readthedocs.io/en/stable/readme.html.
`store` is an extra that uses [this
package](https://github.com/henryiii/validate-pyproject-schema-store) to
get a weekly update of the schema in SchemaStore.

## Test Plan

Step passes on CI, and testing the same command locally while
voluntarily using a wrong classifier fails:
```console
$ uvx --from 'validate-pyproject[all,store]' validate-pyproject pyproject.toml
Invalid file: pyproject.toml
[ERROR] `project.classifiers[5]` must be trove-classifier
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Internal testing of behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants