Validate nested attribute values using specs#53
Merged
Conversation
AVMContainer now validates attribute values against the AVM specs when setting nested attributes (e.g., avm.Spatial.ReferencePixel). Previously, nested attributes bypassed all validation. This also fixes several latent bugs in datatypes exposed by the new validation: - AVMFloat.check_data now correctly handles 0.0 (was treating it as None) - AVMString.check_data now accepts numeric values and converts them to strings - AVMOrderedFloatList.check_data now accepts tuples and native floats Fixes #38
astrofrog
force-pushed
the
fix-nested-attribute-verification
branch
from
d1c615e to
078eb3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AVMContainer now validates attribute values against the AVM specs when setting nested attributes (e.g., avm.Spatial.ReferencePixel). Previously, nested attributes bypassed all validation.
This also fixes several latent bugs in datatypes exposed by the new validation:
Fixes #38