feat: work on styling #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderniebuhr
requested changes
Apr 16, 2024
apps/site/tsconfig.json
Outdated
| @@ -3,7 +3,10 @@ | |||
| "references": [], | |||
| "compilerOptions": { | |||
| "outDir": "../../.moon/cache/types/apps/site", | |||
| "paths": {}, | |||
| "baseUrl": ".", | |||
There was a problem hiding this comment.
Is there any other reason for this besides that the imports are based on the root instead of relative to the file?
There was a problem hiding this comment.
personal preferences, i like using aliases
There was a problem hiding this comment.
I can live with the aliases, I don't really like that non aliased imports are based on the root. AFAIK, path aliases work also without baseUrl in newer typescript version. related PR
There was a problem hiding this comment.
I tried to remove baseUrl but it didn't work, does it require updates to paths as well?
Co-authored-by: Alexander Niebuhr <[email protected]>
alexanderniebuhr
approved these changes
Apr 17, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
* updates moon * rewrites pages to use layout * adds preview deployment automation * improves preview workflows * adds :sync task * disables :check task (temporarily) * updates deps * adds GitHub deployments * adapts styles for starlight * fixes formatting * fixes pipeline * removes broken dark variant (temporarily) * refactors workflow scripts to esm * fixes lockfile * improves setup * tries to solve conflicts * tries to solve conflicts * cleans package.json * fixes install * adds new design (#20) * improves font loading performance (#22) Co-authored-by: Florian Lefebvre <[email protected]> * improvements (#23) * adds AstroStudio CMS announcement (#21) Co-authored-by: Adam Matthiesen <[email protected]> Co-authored-by: Paul Valladares <[email protected]> Co-authored-by: Jacob Jenkins <[email protected]> * fixes blog frontmatter * adds announcement for `astro-theme-provider` (#19) * Update apps/site/src/content/blog/astro-theme-provider.mdx * Update apps/site/src/content/blog/astro-theme-provider.mdx * Update apps/site/src/content/blog/astro-theme-provider.mdx * Update apps/site/src/content/blog/astro-theme-provider.mdx * Update apps/site/src/content/blog/astro-theme-provider.mdx * Update apps/site/src/content/blog/astro-theme-provider.mdx * Update apps/site/src/content/blog/astro-theme-provider.mdx * Update apps/site/src/content/blog/astrostudio-cms.mdx * Update apps/site/src/content/blog/astrostudio-cms.mdx * support multiple authors * fix build * update projects overview --------- Co-authored-by: Florian Lefebvre <[email protected]> Co-authored-by: Paul Valladares <[email protected]> Co-authored-by: Adam Matthiesen <[email protected]> Co-authored-by: Jacob Jenkins <[email protected]> Co-authored-by: Bryce Russell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.