Initial implementation of almanac discovery API#103
Merged
delucchi-cmu merged 13 commits intomainfrom Jun 21, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #103 +/- ##
==========================================
+ Coverage 99.78% 99.83% +0.04%
==========================================
Files 34 41 +7
Lines 950 1181 +231
==========================================
+ Hits 948 1179 +231
Misses 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
smcguire-cmu
left a comment
smcguire-cmu
left a comment
There was a problem hiding this comment.
A few comments, mostly about clarifying some things. Sorry it took a while to go through, it took me a few reads to get how the Almanac and all the catalog infos are initialized, but I think it makes sense!
delucchi-cmu
commented
Jun 14, 2023
Contributor
Author
delucchi-cmu
left a comment
delucchi-cmu
left a comment
There was a problem hiding this comment.
Thanks for your thorough review and great suggestions!
maxwest-uw
reviewed
Jun 20, 2023
Contributor
maxwest-uw
left a comment
maxwest-uw
left a comment
There was a problem hiding this comment.
looks good!! just had one question
maxwest-uw
approved these changes
Jun 21, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Initial implementation of almanac discovery API
Solution Description
This also adds a "factory" for generating typed catalog info that can be used by the almanac to parse the relevant fields.
Code Quality