Skip to content

Use stable sort.#105

Merged
delucchi-cmu merged 1 commit intomainfrom
delucchi/104/sort
Jun 20, 2023
Merged

Use stable sort.#105
delucchi-cmu merged 1 commit intomainfrom
delucchi/104/sort

Conversation

@delucchi-cmu
Copy link
Copy Markdown
Contributor

Force use of stable sort in np.argsort. See issue #104

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 20, 2023

Codecov Report

Merging #105 (8d0ed0d) into main (43f80a2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          34       34           
  Lines         950      950           
=======================================
  Hits          948      948           
  Misses          2        2           
Impacted Files Coverage Δ
src/hipscat/pixel_math/hipscat_id.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@delucchi-cmu delucchi-cmu requested a review from drewoldag June 20, 2023 16:43
Copy link
Copy Markdown

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Seems like there were lots of folks who were hit by the update from numpy 1.24 to 1.25. 😭

@delucchi-cmu delucchi-cmu merged commit 8a53dc8 into main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants