Skip to content

Mechanical application of black formatting#107

Merged
delucchi-cmu merged 1 commit intomainfrom
issue/43/black
Jun 30, 2023
Merged

Mechanical application of black formatting#107
delucchi-cmu merged 1 commit intomainfrom
issue/43/black

Conversation

@delucchi-cmu
Copy link
Copy Markdown
Contributor

@delucchi-cmu delucchi-cmu commented Jun 30, 2023

Change Description

Closes issues #43

  • Adds configuration for black and isort in the pyproject.toml file.
  • Run black . and isort . on the repo
  • Updated line length in .pylintrc files to match the black config
$ pylint -rn -sn --rcfile ./src/.pylintrc ./src/

has no findings

$ pylint -rn -sn --rcfile ./tests/.pylintrc ./tests/

still has a number of findings. these can be addressed in follow-up PRs.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 30, 2023

Codecov Report

Merging #107 (836fa7e) into main (95d6cb2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files          41       41           
  Lines        1181     1181           
=======================================
  Hits         1179     1179           
  Misses          2        2           
Impacted Files Coverage Δ
...catalog/association_catalog/association_catalog.py 100.00% <100.00%> (ø)
src/hipscat/catalog/catalog.py 100.00% <100.00%> (ø)
src/hipscat/catalog/dataset/base_catalog_info.py 100.00% <100.00%> (ø)
...rc/hipscat/catalog/dataset/catalog_info_factory.py 100.00% <100.00%> (ø)
src/hipscat/catalog/dataset/dataset.py 100.00% <100.00%> (ø)
src/hipscat/catalog/partition_info.py 100.00% <100.00%> (ø)
src/hipscat/inspection/almanac.py 100.00% <100.00%> (ø)
src/hipscat/inspection/almanac_info.py 100.00% <100.00%> (ø)
src/hipscat/inspection/visualize_catalog.py 100.00% <100.00%> (ø)
src/hipscat/io/__init__.py 100.00% <100.00%> (ø)
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants