Add Catalog Alignment class and functions#110
Merged
smcguire-cmu merged 18 commits intomainfrom Jul 14, 2023
Merged
Conversation
# Conflicts: # src/hipscat/catalog/__init__.py # src/hipscat/catalog/association_catalog/__init__.py # src/hipscat/catalog/association_catalog/association_catalog.py # src/hipscat/pixel_tree/pixel_tree.py # src/hipscat/pixel_tree/pixel_tree_builder.py
jeremykubica
requested changes
Jul 11, 2023
Contributor
jeremykubica
left a comment
jeremykubica
left a comment
There was a problem hiding this comment.
I went through the design document and it clarified some of my questions. Thanks!
Co-authored-by: Melissa DeLucchi <113376043+delucchi-cmu@users.noreply.github.com>
Co-authored-by: Melissa DeLucchi <113376043+delucchi-cmu@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 99.83% 99.85% +0.02%
==========================================
Files 41 44 +3
Lines 1181 1382 +201
==========================================
+ Hits 1179 1380 +201
Misses 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jeremykubica
approved these changes
Jul 14, 2023
Contributor
jeremykubica
left a comment
jeremykubica
left a comment
There was a problem hiding this comment.
This looks really good. The new comments make it easier to follow and the tests have good cases.
I added one suggestion to the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Creates the
CatalogAlignmentclass to represent the alignment between catalogs. This includes a table with the pixel-to-pixel mapping between the files in each catalog, and the resulting tree from selecting the highest level of partitioning in each branch.Adds functions to compute the alignment between catalogs. This includes adding functionality to the
PixelTreeBuilderclass.resolves #9
Solution Description
The algorithm to perform the catalog alignment is described in detail in this design document
Code Quality
New Feature Checklist