Fix mismatched destination pixel map behavior#112
Merged
delucchi-cmu merged 3 commits intomainfrom Jul 12, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #112 +/- ##
=======================================
Coverage 99.83% 99.83%
=======================================
Files 41 41
Lines 1181 1181
=======================================
Hits 1179 1179
Misses 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jeremykubica
approved these changes
Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Under some conditions, the destination pixel map produced by
compute_pixel_maphas different destination pixels than that produced bygenerate_destination_pixel_map, using a pre-defined alignment array. In this situation, the alignment and the pixel map will not agree on the correct pixels.This manifested in the hipscat-import catalog creation splitting inputs according to the alignment, and trying to reduce them according to the destination pixel map, and not finding the appropriate files.
Bug Fix Checklist