Skip to content

Add healpix_to_hipscat_id conversion#118

Merged
smcguire-cmu merged 7 commits intomainfrom
sean/healpix-to-hipscat-id
Aug 1, 2023
Merged

Add healpix_to_hipscat_id conversion#118
smcguire-cmu merged 7 commits intomainfrom
sean/healpix-to-hipscat-id

Conversation

@smcguire-cmu
Copy link
Copy Markdown
Contributor

Change Description

Adds the healpix_to_hipscat_id function to get a hipscat_id for a specified HEALPix pixel. This is useful for operations like efficiently filtering rows within a given file.

Solution Description

Converts the given pixel to order 19, and performs the same calculation to generate the hipscat_id as when computing a hipscat id from ra/dec. This computation has been refactored to be used by both methods.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 1, 2023

Codecov Report

Merging #118 (33bb93b) into main (c2ec85c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #118   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines         1322      1332   +10     
=========================================
+ Hits          1322      1332   +10     
Files Changed Coverage Δ
src/hipscat/pixel_tree/pixel_alignment.py 100.00% <ø> (ø)
src/hipscat/pixel_math/hipscat_id.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread tests/hipscat/pixel_math/test_hipscat_id.py Outdated
Comment thread tests/hipscat/pixel_math/test_hipscat_id.py Outdated
smcguire-cmu and others added 4 commits August 1, 2023 13:50
@smcguire-cmu smcguire-cmu merged commit 1127da5 into main Aug 1, 2023
@smcguire-cmu smcguire-cmu deleted the sean/healpix-to-hipscat-id branch August 1, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants