Skip to content

Add method to get filepointer's basename#132

Merged
delucchi-cmu merged 2 commits intomainfrom
delucchi/healpix
Sep 20, 2023
Merged

Add method to get filepointer's basename#132
delucchi-cmu merged 2 commits intomainfrom
delucchi/healpix

Conversation

@delucchi-cmu
Copy link
Copy Markdown
Contributor

Change Description

Add a method to get the basename of a filepointer object. e.g. find catalog_info.json from /path/to/catalogs/ps1/catalog_info.json

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@github-actions
Copy link
Copy Markdown

Before After Ratio Method
[a95bb4d] [282b1e6]
702±3ms 701±5ms 1 benchmarks.time_test_cone_filter_multiple_order
172±10ms 157±1ms 0.92 benchmarks.time_test_alignment_even_sky

Click here to view all benchmarks.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 14, 2023

Codecov Report

Merging #132 (eb92c48) into main (ea8bc17) will not change coverage.
Report is 12 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #132   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines         1363      1365    +2     
=========================================
+ Hits          1363      1365    +2     
Files Changed Coverage Δ
src/hipscat/io/file_io/__init__.py 100.00% <ø> (ø)
src/hipscat/io/file_io/file_io.py 100.00% <ø> (ø)
src/hipscat/io/file_io/file_pointer.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Copy Markdown

Before After Ratio Method
[a95bb4d] [dbcfde1]
215±2ms 213±0.5ms 0.99 benchmarks.time_test_alignment_even_sky
794±7ms 774±3ms 0.97 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit afc165a into main Sep 20, 2023
@delucchi-cmu delucchi-cmu deleted the delucchi/healpix branch October 24, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants