Skip to content

Update to PPT v1.4.3#143

Merged
delucchi-cmu merged 1 commit intomainfrom
delucchi/copier
Oct 11, 2023
Merged

Update to PPT v1.4.3#143
delucchi-cmu merged 1 commit intomainfrom
delucchi/copier

Conversation

@delucchi-cmu
Copy link
Copy Markdown
Contributor

Change Description

Runs copier update to use new template version. Moves the new "getting started dev guide" to expand on environment setup instructions in the contribution guide.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@github-actions
Copy link
Copy Markdown

Before After Ratio Method
[da10c3a] [f818cf2]
172±2ms 168±3ms 0.98 benchmarks.time_test_cone_filter_multiple_order
215±3ms 209±3ms 0.97 benchmarks.time_test_alignment_even_sky
1.29±0.01s 1.25±0.01s 0.97 benchmarks.Suite.time_pixel_tree_creation

Click here to view all benchmarks.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 10, 2023

Codecov Report

Merging #143 (467acc8) into main (da10c3a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #143   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           46        46           
  Lines         1523      1505   -18     
=========================================
- Hits          1523      1505   -18     

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@delucchi-cmu delucchi-cmu requested a review from hombit October 10, 2023 20:05
Copy link
Copy Markdown
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the only real question I have is about setuptools_scm to be a runtime dep

Comment thread pyproject.toml
Comment thread src/.pylintrc
Comment thread tests/.pylintrc
@delucchi-cmu delucchi-cmu merged commit 0351780 into main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants