Skip to content

Add paths method for getting multiple paths#258

Merged
smcguire-cmu merged 4 commits intomainfrom
sean/paths
Apr 17, 2024
Merged

Add paths method for getting multiple paths#258
smcguire-cmu merged 4 commits intomainfrom
sean/paths

Conversation

@smcguire-cmu
Copy link
Copy Markdown
Contributor

@smcguire-cmu smcguire-cmu commented Apr 12, 2024

Looping through pixel_catalog_file can be inefficient, so add pixel_catalog_files method which generates multiple paths.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.74%. Comparing base (10e527d) to head (238c074).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
+ Coverage   95.72%   95.74%   +0.01%     
==========================================
  Files          56       56              
  Lines        1873     1880       +7     
==========================================
+ Hits         1793     1800       +7     
  Misses         80       80              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 12, 2024

Before [af5806a] After [7e64f04] Ratio Benchmark (Parameter)
failed 20.3±0.5ms n/a benchmarks.MetadataSuite.time_load_partition_info_order6
failed 77.2±0.5ms n/a benchmarks.MetadataSuite.time_load_partition_info_order7
failed 77.2±0.3ms n/a benchmarks.MetadataSuite.time_load_partition_join_info
failed 86.6±3ms n/a benchmarks.Suite.time_paths_creation
failed 46.9±0.6ms n/a benchmarks.Suite.time_pixel_tree_creation
failed 124±0.2ms n/a benchmarks.time_test_alignment_even_sky
failed 13.7±0.1ms n/a benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

Copy link
Copy Markdown
Contributor

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

It'd be great to check how much it improved - can you add a benchmark test to this?

Comment thread src/hipscat/io/paths.py Outdated
smcguire-cmu and others added 2 commits April 15, 2024 19:00
Co-authored-by: Melissa DeLucchi <113376043+delucchi-cmu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants