Capture compression and open binary if present.#419
Merged
delucchi-cmu merged 2 commits intomainfrom Nov 14, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 92.99% 93.02% +0.03%
==========================================
Files 49 47 -2
Lines 2127 2123 -4
==========================================
- Hits 1978 1975 -3
+ Misses 149 148 -1 ☔ View full report in Codecov by Sentry. |
Click here to view all benchmarks. |
hombit
approved these changes
Nov 14, 2024
Contributor
hombit
left a comment
There was a problem hiding this comment.
Thank you! I have few questions
- I don't really understand where decompression is happening - could you point on that code?
- Could you please add a high-level test for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
compressionkwarg, when provided, should be used when opening the file, but should NOT be passed along topandas.read_csv. This captures the value in a named argument so it can be used in the file opening.Further, if some compression is provided, we change the read mode to
"rb", as compression implies that the underlying file is not plain text.Closes #407
Closes astronomy-commons/hats-import#425