Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## margin #426 +/- ##
==========================================
+ Coverage 92.86% 92.87% +0.01%
==========================================
Files 46 46
Lines 2031 2034 +3
==========================================
+ Hits 1886 1889 +3
Misses 145 145 ☔ View full report in Codecov by Sentry. |
delucchi-cmu
approved these changes
Nov 19, 2024
delucchi-cmu
added a commit
that referenced
this pull request
Nov 26, 2024
* Remove margin fine filtering. * Remove unused unseen. * Remove margin fine filtering. (#421) * Remove margin fine filtering. * Remove unused unseen. * Use cdshealpix for margin pixel finding. * Unused import. * add color_by_order option and plot on existing axes * reset matplotlib after tests * pylint * Migrate ang2vec (#426) * Use astropy for ang2vec conversion * Allow for kwargs in ang2vec * use mindist instead of resol for margin filter * Replace healpy in healpix_shim pixel math operations * isort * support np arrays * use order instead of nside * remove unused variable * Return int64 from radec2pix (#432) * Migrate box filtering to use MOCpy (#428) * Use mocpy in box filtering * Update tests * Ensure moc is correct in box filter test * Remove unused healpy methods * Pin mocpy * Remove healpy references. (#433) * Address merge conflicts --------- Co-authored-by: Sean McGuire <123987820+smcguire-cmu@users.noreply.github.com> Co-authored-by: Sean McGuire <seanmcgu@andrew.cmu.edu> Co-authored-by: Sandro Campos <scampos@andrew.cmu.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use astropy to convert ra/dec coordinates to unit cartesian vectors. Part of issue #423.
Code Quality