Add mem_size histogram support to generate_alignment#599
Merged
olivialynn merged 15 commits intomainfrom Nov 26, 2025
Merged
Conversation
Click here to view all benchmarks. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
==========================================
+ Coverage 92.83% 92.89% +0.06%
==========================================
Files 49 49
Lines 2234 2253 +19
==========================================
+ Hits 2074 2093 +19
Misses 160 160 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
…ow_count, mem_size)
Contributor
delucchi-cmu
left a comment
There was a problem hiding this comment.
This looks good so far - just the remaining comment about 4-tuple -> 3-tuple
…it is no longer used at that point)
delucchi-cmu
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Along with astronomy-commons/hats-import#631, this will close astronomy-commons/hats-import#449.
Solution Description
(order, pixel, row_count).(order, pixel, mem_size, row_count), which is used for partitioning logic when partitioning by memory size.row_countof each pixel in the alignment file, as this allows us to quickly guarantee that all rows have been accounted for throughout the various stages of the pipeline.