Skip to content

Add mem_size histogram support to generate_alignment#599

Merged
olivialynn merged 15 commits intomainfrom
u/olynn/mem_size_alignment
Nov 26, 2025
Merged

Add mem_size histogram support to generate_alignment#599
olivialynn merged 15 commits intomainfrom
u/olynn/mem_size_alignment

Conversation

@olivialynn
Copy link
Copy Markdown
Member

@olivialynn olivialynn commented Nov 20, 2025

Change Description

Along with astronomy-commons/hats-import#631, this will close astronomy-commons/hats-import#449.

Solution Description

  • Alignment files traditionally include tuples of length 3: (order, pixel, row_count).
  • This change extends them to (optionally) have an additional element: (order, pixel, mem_size, row_count), which is used for partitioning logic when partitioning by memory size.
  • We preserve data about the row_count of each pixel in the alignment file, as this allows us to quickly guarantee that all rows have been accounted for throughout the various stages of the pipeline.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 20, 2025

Before [53a04bc] After [f1d5d29] Ratio Benchmark (Parameter)
12.4±0.4ms 12.8±0.5ms 1.03 benchmarks.Suite.time_inner_pixel_alignment
353±2ms 352±1ms 1 benchmarks.Suite.time_outer_pixel_alignment
105±0.4ms 105±0.4ms 1 benchmarks.time_test_alignment_even_sky
1.04±0.03ms 1.05±0.03ms 1 benchmarks.time_test_cone_filter_multiple_order
36.3±0.6ms 36.0±0.2ms 0.99 benchmarks.Suite.time_pixel_tree_creation
226±3ms 224±0.8ms 0.99 benchmarks.time_open_large_catalog
36.4±0.09ms 35.9±0.2ms 0.99 benchmarks.time_open_midsize_catalog
227±0.9ms 226±2ms 0.99 benchmarks.time_small_cone_large_catalog

Click here to view all benchmarks.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.89%. Comparing base (53a04bc) to head (9ac5477).
⚠️ Report is 71 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
+ Coverage   92.83%   92.89%   +0.06%     
==========================================
  Files          49       49              
  Lines        2234     2253      +19     
==========================================
+ Hits         2074     2093      +19     
  Misses        160      160              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@olivialynn olivialynn marked this pull request as ready for review November 20, 2025 14:19
Copy link
Copy Markdown
Contributor

@delucchi-cmu delucchi-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good so far - just the remaining comment about 4-tuple -> 3-tuple

@olivialynn olivialynn merged commit 644a889 into main Nov 26, 2025
12 checks passed
@olivialynn olivialynn deleted the u/olynn/mem_size_alignment branch November 26, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an option to set pixel threshold in bytes

2 participants