This repository was archived by the owner on Nov 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 43
Proof of concept: refactor astropy-helpers into extension-helpers #503
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfo to get_extensions
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
===========================================
- Coverage 41.37% 29.96% -11.42%
===========================================
Files 19 9 -10
Lines 1670 534 -1136
===========================================
- Hits 691 160 -531
+ Misses 979 374 -605
Continue to review full report at Codecov.
|
Do you also plan to rename the repo? |
Or maybe this really should be a new repo? If you insist to have this here, should at least branch out the "old way" in case others need to patch it for one reason or another. |
The "old-way" is already been branched out into 2.0.x, 3.y.x, 4.0.x etc branches. |
Closing as this branch has now been pushed to https://github.com/astropy/extension-helpers |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion PR to astropy/astropy#9726 and APE 17 and demonstrates how we can remove most of the functionality into astropy-helpers, keeping only utilities related to compiling C and Cython extensions. The remaining functionality is:
setup_package.py
filesThis also renames astropy-helpers to extension-helpers to reflect its new purpose and the fact it is very general and can be used beyond the project. This should not be merged at this point and is up to easily be able to visualize the changes that would be required.
For experimenting purposes, I have uploaded an alpha release to PyPI: https://pypi.org/project/extension-helpers/