Skip to content

Add PyAutoLens as AstroPy Affiliated Package #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

Jammy2211
Copy link

We are requesting affiliated status for our package PyAutoLens :).

Copy link
Contributor

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for proposing this package as an affiliated package to the Astropy project. I am presently searching for a reviewer to provide a detailed review; in the meantime I am only asking to make the suggested formal/formatting adjustments to the registry.

Comment on lines 9 to 10
"pypi_name": "https://pypi.org/project/autolens/",
"description": "Analysis, modeling and simulations of strong gravitational lenses.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"pypi_name": "https://pypi.org/project/autolens/",
"description": "Analysis, modeling and simulations of strong gravitational lenses.",
"pypi_name": "autolens",
"description": "Analysis, modeling and simulations of strong gravitational lenses.",
"coordinated": false,

Only use "project" name on PyPI; + required field.

@dhomeier
Copy link
Contributor

dhomeier commented Jul 1, 2022

Apologies for the delay as it took some time to find a referee familiar with this field of research. I am however happy to confirm that your package is now under review and we'll post the results of the review here and on the mailing list.
In the meantime I would merely suggest that you add a CITATION file to the main repo containing the principal information of the Citations section in your docs on how to cite your package, so it would be more visible to users of the package.

@Jammy2211
Copy link
Author

Apologies for the delay as it took some time to find a referee familiar with this field of research. I am however happy to confirm that your package is now under review and we'll post the results of the review here and on the mailing list. In the meantime I would merely suggest that you add a CITATION file to the main repo containing the principal information of the Citations section in your docs on how to cite your package, so it would be more visible to users of the package.

Excellent thank you!

We have a citations section on our docs (https://pyautolens.readthedocs.io/en/latest/general/citations.html) but will also add a CITATION file as all visibility is good visibilitiy!

@hamogu
Copy link
Member

hamogu commented Mar 4, 2025

@dhomeier @Jammy2211: What is the status of this submission? It seems like this somehow dropped of the radar for use astropy-affiliated editors (I've taken over for @pllim since this issue was opened, @dhomeier is still on the job) as surely it can't take the referee three years to look at this package.

I am really, really sorry about that - it's clearly a breakdown in our process - but I want to look forward and see how we can fix it. Maybe the easiest is to go through PyOpenSci with a new submission at this time?

@Jammy2211
Copy link
Author

I think with PyAutoGalaxy, the process began on there and never got round to PyAutoLens (which is a similar review as they are child / parent packages).

It sounds like you're getting the proess on PyAutoGalaxy going again, so lets get that rolling and then we can sort PyAutoLEns -- you can either try do them both simultaneouisly or one after another.

Part of its my fault -- I got buried in doing actual science for a few years and had to take a back seat on development :)

@hamogu
Copy link
Member

hamogu commented Mar 5, 2025

I wouldn't call "doing science" a fault. Isn't that why we write all this software in the first place?

@hamogu
Copy link
Member

hamogu commented Mar 5, 2025

Unless they are packaged together, we should review them as separate packages I think; they have different repros, different DOIs, etc.

@hamogu hamogu closed this Mar 5, 2025
@hamogu
Copy link
Member

hamogu commented Mar 5, 2025

I'm closing this based on this discussion and expect to see it in PyOpenSci some time after PyAutoGalaxy!
Don't be surprised that there are still other similar PRs open here. Our goal is transfer them to PyOpenSci one-by-one and not all at once because that would make it harder to find reviewers. PyAutoGalaxy looks the most ready, so I'm starting with your two packages!

@dhomeier
Copy link
Contributor

Thanks @Jammy2211 , I had assumed PyAutoLens would stay on hold as long as PyAutoGalaxy, but should have investigated again after a few months! Submitting this next to pyOpenSci should be the best path to get things rolling again, and will give you the opportunity to familiarise yourself with the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants