-
-
Notifications
You must be signed in to change notification settings - Fork 418
GAIA: new simplified cross match method #3320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cosmoJFH
wants to merge
11
commits into
astropy:main
Choose a base branch
from
esdc-esac-esa-int:ESA_gaia_GAIASWRQ-25_improve_cross-match
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
GAIA: new simplified cross match method #3320
cosmoJFH
wants to merge
11
commits into
astropy:main
from
esdc-esac-esa-int:ESA_gaia_GAIASWRQ-25_improve_cross-match
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b401d75
to
3442e97
Compare
a80c138
to
dc0fac9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3320 +/- ##
==========================================
+ Coverage 69.88% 69.97% +0.08%
==========================================
Files 232 232
Lines 19761 19814 +53
==========================================
+ Hits 13810 13864 +54
+ Misses 5951 5950 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
16f6ca6
to
cedfc7e
Compare
63a18b0
to
2278697
Compare
37ed467
to
a8b1654
Compare
49dbbfe
to
34b324d
Compare
7fb5b9d
to
e63ae6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear astroquery team,
The current implementation of the astroquery.gaia built-in cross-match tool relies in a sub-optimal intermediate ADQL query. Furthermore (and after uploading a table to the user space), it requires a 3-step approach involving different functionalities (each of them requiring multiple "user clicks"):
We propose to streamline this procedure to improve the user experience and hopefully promote the usage of this functionality by updating the current implementation.
The proposed mechanism:
We have developed the new method cross_match_basic as well as new tests. This change is backward compatible with the present implementation of the cross-match method.
cc @esdc-esac-esa-int
jira: GAIASWRQ-25