Skip to content

missing must_use for writeln on File #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fenhl opened this issue Dec 14, 2019 · 0 comments · Fixed by #628
Closed

missing must_use for writeln on File #627

fenhl opened this issue Dec 14, 2019 · 0 comments · Fixed by #628

Comments

@fenhl
Copy link
Contributor

fenhl commented Dec 14, 2019

I'm having a hard time finding the exact definitions that are relevant because everything is macros so I'm not sure where exactly the error is, but I had some code that tried to writeln! to an async_std::fs::File but forgot to await it, and didn't get any unused-must-use lints.
fenhl added a commit to fenhl/async-std that referenced this issue Dec 14, 2019
@fenhl
Make WriteFmtFuture must_use
07eb2c1 
Fixes async-rs#627. Thanks to @jebrosen for pointing out the location of the issue.
@fenhl fenhl mentioned this issue Dec 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make WriteFmtFuture must_use fenhl/async-std
1 participant
@fenhl