-
Notifications
You must be signed in to change notification settings - Fork 341
fix wasm and nostd builds #863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jbr @yoshuawuyts any ideas about the CI issues, they are quite odd. Suddenly there are missing crates Oo, seems like a CI bug, as this works fine locally. |
Agreed that it seems to be a CI issue, but I don't think it's related to this PR. See CI failures at https://github.com/async-rs/async-std/pull/853/checks?check_run_id=988260537 Maybe it's related to caching? Does it help to temporarily comment out L32-48 of ci.yml? |
@dignifiedquire See the above PR for a possible long-term solution to the wasm/no-std problem, but at the cost of requiring all wasm users to enable a |
d0d277d
to
1e5d42e
Compare
This seems fine to me, although me and @jbr were discussing with @yoshuawuyts last week and Yosh noted that just getting it to build may not be enough and actual was builds could still have issues when run in their environments. I'm not so invested in that personally but is something that may be good to track, both for async-std and http-rs. |
yes we need to run the tests as well, I had wasm-bindgen-test working at some point on my machine, but forgot the magical invocations.. |
Closes #861,#843