Skip to content

feat: implement horizontal footer layout with modern social media icons#763

Merged
AceTheCreator merged 38 commits into
asyncapi:masterfrom
Recxsmacx:Footer-socials
Feb 11, 2026
Merged

feat: implement horizontal footer layout with modern social media icons#763
AceTheCreator merged 38 commits into
asyncapi:masterfrom
Recxsmacx:Footer-socials

Conversation

@Recxsmacx

Copy link
Copy Markdown
Contributor

Related to #659

Enhance the social section of the website to improve user engagement and interactivity.

Footer Component Changes:

Replace the hardcoded social media links with a new Socials component.
Add hover effects and tooltips for social media icons.
Add onClick event handlers to redirect users to respective social media pages.
Increase the gap between the "Code of Conduct" link and the line in the footer by adding margin to the a element.
Socials Component:

Create a new Socials component to handle social media icons.
Add LinkedIn, GitHub, Twitter, and YouTube icons with respective onClick event handlers.
Add tooltips for each social media icon to provide additional context.
Add hover effects to make the icons more visually appealing.

- Refactor footer to use consistent horizontal layout across all screen sizes
- Create new Socials component with custom styled circular icons
- Add interactive tooltips with platform-specific hover colors
- Update Cypress tests to include social media icon testing
- Add CSS styles for tooltip animations and hover effects
- Replace image-based icons with inline SVG for better performance

Changes:
- components/Footer/footer.tsx: horizontal layout with flex-wrap
- components/Footer/socials.tsx: new component with LinkedIn, GitHub, Twitter, YouTube
- cypress/e2e/Footer.cy.ts: enhanced test suite with social media tests
- styles/globals.css: tooltip styles and hover animations
@netlify

netlify Bot commented Jul 8, 2025

Copy link
Copy Markdown

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 3546c7b
🔍 Latest deploy log https://app.netlify.com/projects/peaceful-ramanujan-288045/deploys/698cd2e30a531f0008d1bea5
😎 Deploy Preview https://deploy-preview-763--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

- Add .show-for-test class support to make tooltips visible during testing
- Use !important to override default opacity: 0 for test scenarios
- All 12 Cypress tests now passing including tooltip visibility tests

@AceTheCreator AceTheCreator left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really, @Recxsmacx. Can you make it responsive on small screen?

@Recxsmacx
Recxsmacx requested a review from AceTheCreator July 10, 2025 12:12

@AceTheCreator AceTheCreator left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Recxsmacx, what I meant by making it responsive is simply adjusting the footer layout to collapse from a row into a column on smaller screens, not just making the text smaller.

@Recxsmacx
Recxsmacx requested a review from AceTheCreator July 12, 2025 09:37
@Recxsmacx

Copy link
Copy Markdown
Contributor Author

@Recxsmacx, what I meant by making it responsive is simply adjusting the footer layout to collapse from a row into a column on smaller screens, not just making the text smaller.

@AceTheCreator I kept it the old way on smaller screens the code of conduct button vanishes to keep the footer look clean and not messy wdyt?
rest the responsiveness is done

@AceTheCreator AceTheCreator left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary code formatter changes in this file

@AceTheCreator

Copy link
Copy Markdown
Member

Kindly resolve the conflicts, so we can merge it

@AceTheCreator AceTheCreator left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discard changes made under cypress/download

- Resolved conflicts in footer.tsx by keeping Socials component while using master's import style
- Resolved conflicts in Footer.cy.ts by integrating close-button clicks from master with social media tooltip tests
- All functionality preserved from both branches
- Fix TypeScript error in socials.tsx by importing JSX
- Install @types/react-dom to resolve popup component build error
- Maintain functionality while ensuring type safety
- Add conf 2025.pdf to cypress/Downloads directory
- Document contains conference information and schedule
- Referenced in Cypress tests for download functionality
@namanjain24-sudo

Copy link
Copy Markdown

@Recxsmacx can i work on this issue if u are not working on it ?

@AceTheCreator AceTheCreator left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left you some reviews @Recxsmacx

Comment thread components/Footer/socials.tsx Outdated
Comment thread cypress/e2e/Footer.cy.ts
Comment thread cypress/e2e/Footer.cy.ts Outdated
Comment thread cypress/Downloads/conf 2025.pdf Outdated
Comment thread package.json
Comment thread package-lock.json
Comment thread styles/globals.css

@AceTheCreator AceTheCreator left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left you some final review @Recxsmacx

Comment thread styles/globals.css

@princerajpoot20 princerajpoot20 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the comment.

Comment thread styles/globals.css
@Recxsmacx

Copy link
Copy Markdown
Contributor Author

@princerajpoot20 can you check this!! resolved the possible formatting changes cc:- @AceTheCreator

@Recxsmacx

Copy link
Copy Markdown
Contributor Author

@AceTheCreator it's done from my side please need your final reviews

@AceTheCreator AceTheCreator left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left you some review @Recxsmacx

Comment thread cypress/e2e/Footer.cy.ts Outdated
Comment thread components/Footer/socials.tsx Outdated
Comment thread cypress/e2e/Footer.cy.ts
@Recxsmacx

Copy link
Copy Markdown
Contributor Author

@AceTheCreator need your check on the changes

@Recxsmacx

Copy link
Copy Markdown
Contributor Author

@AceTheCreator you fine with the changes?

@AceTheCreator AceTheCreator left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@AceTheCreator
AceTheCreator merged commit 06e7f05 into asyncapi:master Feb 11, 2026
13 checks passed
@Recxsmacx

Copy link
Copy Markdown
Contributor Author

Finally after 9 months lol 😂😂😂
Thanks for the patience @AceTheCreator

@Recxsmacx
Recxsmacx deleted the Footer-socials branch July 15, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants