feat: button story Components and Component reusability #809
Merged
Conversation
TenzDelek
requested review from
AceTheCreator,
Mayaleeeee,
ashmit-coder and
thulieblack
as code owners
September 27, 2025 04:51
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
TenzDelek
changed the title
AceTheCreator
requested changes
Oct 10, 2025
Member
|
The center icon looks a bit off as a button. It’s fine to wrap it in a div and style it using an anchor tag instead; it doesn’t really need to be a button element. 
|
Member
Author
|
thank you for review @AceTheCreator , will make the changes as stated |
Member
Author
|
@AceTheCreator @ashmit-coder ready for review |
AceTheCreator
left a comment
AceTheCreator
left a comment
Member
There was a problem hiding this comment.
Left you some final comment @TenzDelek
TenzDelek
marked this pull request as draft
December 21, 2025 13:22
TenzDelek
marked this pull request as ready for review
December 21, 2025 13:34
Member
Author
|
sorry for the delay. pinging for review @AceTheCreator @ashmit-coder |
Member
|
/rtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this pr introduces the button story. on top of that we have made changes in the existing component to use the
Buttoncomponent instead of the directbuttonfrom the native.we also introduced a new prop inspire by the main website button component where we take in text and icon as a prop.
Related issue(s)
GSOC